Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code cov #346

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix code cov #346

merged 1 commit into from
Jun 7, 2023

Conversation

mikeshng
Copy link
Member

@mikeshng mikeshng commented Jun 7, 2023

  • I have taken backward compatibility into consideration.

Signed-off-by: Mike Ng <ming@redhat.com>
@openshift-ci openshift-ci bot requested review from jnpacker and xiangjingli June 7, 2023 16:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
@mikeshng mikeshng requested review from lennysgarage and philipwu08 and removed request for jnpacker June 7, 2023 16:50
@xiangjingli
Copy link
Collaborator

/lgtm

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@381ad56). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage        ?   53.98%           
=======================================
  Files           ?       71           
  Lines           ?    14924           
  Branches        ?        0           
=======================================
  Hits            ?     8056           
  Misses          ?     6054           
  Partials        ?      814           
Flag Coverage Δ
unit 53.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants