Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update troubleshooting items and how to patch along with the new 2.8 release #354

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

@openshift-ci openshift-ci bot requested review from jnpacker and philipwu08 June 26, 2023 23:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli requested review from lennysgarage and mikeshng and removed request for jnpacker June 26, 2023 23:02
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.80 ⚠️

Comparison is base (fa39a85) 55.15% compared to head (23c6a1f) 54.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   55.15%   54.36%   -0.80%     
==========================================
  Files          71       71              
  Lines       14924    14924              
==========================================
- Hits         8231     8113     -118     
- Misses       5874     5987     +113     
- Partials      819      824       +5     
Flag Coverage Δ
unit 54.36% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant