Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build parameters #355

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Update build parameters #355

merged 5 commits into from
Jul 6, 2023

Conversation

lennysgarage
Copy link
Member

  • I have taken backward compatibility into consideration.

Addresses CVE-2023-3089

@openshift-ci openshift-ci bot requested review from mikeshng and xiangjingli July 5, 2023 16:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lennysgarage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli
Copy link
Collaborator

/lgtm

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (fa39a85) 55.15% compared to head (090f881) 54.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   55.15%   54.98%   -0.17%     
==========================================
  Files          71       71              
  Lines       14924    14927       +3     
==========================================
- Hits         8231     8208      -23     
- Misses       5874     5901      +27     
+ Partials      819      818       -1     
Flag Coverage Δ
unit 54.98% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng mikeshng force-pushed the update-build branch 2 times, most recently from 22a822a to c28f162 Compare July 5, 2023 23:29
Signed-off-by: testadmin <testadmin@redhat.com>
@xiangjingli
Copy link
Collaborator

/hold

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Signed-off-by: Mike Ng <ming@redhat.com>
xiangjingli and others added 2 commits July 6, 2023 00:27
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng
Copy link
Member

mikeshng commented Jul 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 6, 2023
@xiangjingli
Copy link
Collaborator

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants