Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set subscription-admin cluster role to be the managedclusterset admin #363

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-7147

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d1fd79e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage        ?   54.54%           
=======================================
  Files           ?       71           
  Lines           ?    14948           
  Branches        ?        0           
=======================================
  Hits            ?     8153           
  Misses          ?     5971           
  Partials        ?      824           
Flag Coverage Δ
unit 54.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng August 29, 2023 17:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant