Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitOpsCluster CRD #366

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update GitOpsCluster CRD #366

merged 1 commit into from
Sep 18, 2023

Conversation

mikeshng
Copy link
Member

  • I have taken backward compatibility into consideration.

Signed-off-by: Mike Ng <ming@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.22% 🎉

Comparison is base (14e3907) 54.29% compared to head (430c2e5) 54.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   54.29%   54.52%   +0.22%     
==========================================
  Files          71       71              
  Lines       14947    14947              
==========================================
+ Hits         8116     8150      +34     
+ Misses       6004     5973      -31     
+ Partials      827      824       -3     
Flag Coverage Δ
unit 54.52% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philipwu08
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@mikeshng mikeshng merged commit e5f645f into main Sep 18, 2023
8 checks passed
@mikeshng mikeshng deleted the update-csv branch September 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants