Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all containers run with r/o root fs and other std securityContext settings #373

Merged

Conversation

joeg-pro
Copy link
Contributor

This PR updates the container specs of all ALC deployments to ensure that all containers run with a read-only root filesystem. This is a secure engineering best practice and something users are starting to expect of Kube applications.

The PR also updates securityContext settings at the container and pod levels to bring them into alignment with the standards we are aming for across all things integrated into Stolostron and subsequently RHACM. Some of these settings were already being applied, but inconsistently across the deployments/containers.

Finally, this PR adjusts anti-affinity to conform to key naming that we're using as standard practice for things integrated into Stolostro/RHACM. (These settings are actually being injected this way by the tooling that ingrates things into the MCH operator, but its better that the source-of-truth reflects the settings as desired so there is less "magic" happening via the integration automation.)

…ext settings

Signed-off-by: Joe Gdaniec <jgdaniec@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joeg-pro
Once this PR has been reviewed and has the lgtm label, please assign lennysgarage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng mikeshng requested review from xiangjingli, mikeshng and philipwu08 and removed request for lennysgarage and chenz4027 October 17, 2023 16:00
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (619d1b6) 54.46% compared to head (8b31f2b) 54.07%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   54.46%   54.07%   -0.40%     
==========================================
  Files          71       71              
  Lines       14947    14947              
==========================================
- Hits         8141     8082      -59     
- Misses       5979     6044      +65     
+ Partials      827      821       -6     
Flag Coverage Δ
unit 54.07% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli xiangjingli merged commit c33c61f into open-cluster-management-io:main Oct 17, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants