cve fix: upgrade go-git and other dep libs; Lower MaxConcurrentReconc…

[xiangjingli]

…iles to 1 for helmRelease controller

• I have taken backward compatibility into consideration.

Two issues are fixed:

• lower MaxConcurrentReconciles to 1 for helmRelease controller.
  With the previous 10 concurrent setting, we identified there is OOM killed issue in the footprint assessment test env where the managed cluster is SNO cluster with limited memory. Setting it to 1 stabilized the running of the application-manager pod
  https://issues.redhat.com/browse/ACM-8936

• CVE fixes - upgrade go-git lib and other dep pkg
  https://issues.redhat.com/browse/ACM-9371
  https://issues.redhat.com/browse/ACM-9368

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf0debb) 0.00% compared to head (993305f) 55.59%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main     #382       +/-   ##
=========================================
+ Coverage      0   55.59%   +55.59%     
=========================================
  Files         0       71       +71     
  Lines         0    15315    +15315     
=========================================
+ Hits          0     8514     +8514     
- Misses        0     5948     +5948     
- Partials      0      853      +853     

Flag	Coverage Δ
unit	55.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikeshng]

/approve

/lgtm

[mikeshng]

@xiangjingli side effect of this change is if there is a helm chart that is taking forever to install (for example: a very long running hook job) then all the other helmrelease will be blocked and unable to reconcile. I am guessing this is why the e2e is timing out?

[xiangjingli]

@mikeshng THX! I increased the MaxConcurrentReconciles to 2 and all the e2e tests passed. 2 may be a better choice so that we have the minimum concurrency reconcile capability while we won't hit OOM too often compared to 10

[mikeshng]

/approve

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment