-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm
CLI to image
#388
Add helm
CLI to image
#388
Conversation
/hold for reviews. Is there any reason to not add the |
5655690
to
aaa4486
Compare
/cc @mprahl |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 55.19% 55.54% +0.34%
==========================================
Files 71 71
Lines 15315 15315
==========================================
+ Hits 8453 8506 +53
+ Misses 6017 5955 -62
- Partials 845 854 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
@dhaiducek Just unhold it once your team makes the decision. We are no problem to bundle the helm CLI in the subscription image |
f738ba9
to
e5bc755
Compare
The build worked! 🎉 Waiting on |
/approve |
/unhold |
/hold |
ref: https://issues.redhat.com/browse/ACM-9060 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mikeshng, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
3eac4a9
into
open-cluster-management-io:main
ref: https://issues.redhat.com/browse/ACM-9060