Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm CLI to image #388

Merged

Conversation

dhaiducek
Copy link
Member

ref: https://issues.redhat.com/browse/ACM-9060

  • I have taken backward compatibility into consideration.

@dhaiducek
Copy link
Member Author

/hold for reviews. Is there any reason to not add the helm CLI to the image? Without it, I'm not sure the Helm feature in the Policy Generator can be used as it is (though it still works for ArgoCD since the CLI is present there, so this PR isn't overly critical to merge if there are hesitations.)

@dhaiducek dhaiducek force-pushed the add-helm branch 2 times, most recently from 5655690 to aaa4486 Compare February 9, 2024 17:45
@dhaiducek
Copy link
Member Author

/cc @mprahl

@openshift-ci openshift-ci bot requested a review from mprahl February 9, 2024 17:53
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85bd342) 55.19% compared to head (19e1b75) 55.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   55.19%   55.54%   +0.34%     
==========================================
  Files          71       71              
  Lines       15315    15315              
==========================================
+ Hits         8453     8506      +53     
+ Misses       6017     5955      -62     
- Partials      845      854       +9     
Flag Coverage Δ
unit 55.54% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli
Copy link
Collaborator

/lgtm

@xiangjingli
Copy link
Collaborator

@dhaiducek Just unhold it once your team makes the decision. We are no problem to bundle the helm CLI in the subscription image

@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2024
@dhaiducek dhaiducek force-pushed the add-helm branch 2 times, most recently from f738ba9 to e5bc755 Compare February 12, 2024 17:25
@dhaiducek
Copy link
Member Author

The build worked! 🎉 Waiting on gosec overrides from this PR to be merged:

@mikeshng
Copy link
Member

/approve

@dhaiducek
Copy link
Member Author

/unhold

@xiangjingli
Copy link
Collaborator

/hold

ref: https://issues.redhat.com/browse/ACM-9060
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2024
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli
Copy link
Collaborator

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants