Fix log spam from spoke_token_controller #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
mikeshng
requested review from
rokej and
xiangjingli
and removed request for
lennysgarage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 56.66% 56.35% -0.31%
==========================================
Files 68 68
Lines 15248 15236 -12
==========================================
- Hits 8640 8586 -54
- Misses 5746 5796 +50
+ Partials 862 854 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manuel Grandeit <m.grandeit@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grandeit, mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cd7e6ad
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the log spam of the spoke_token_controller by only logging events that pass the predicate functions.
Removes the following log spam when secrets get updated somewhere in the cluster:
--- SNIP ---
I1030 02:26:00.606725 1 spoke_token_controller.go:432] secret namespace not matched, appAddonNS= open-cluster-management-agent-addon
I1030 02:26:00.864936 1 spoke_token_controller.go:432] secret namespace not matched, appAddonNS= open-cluster-management-agent-addon
I1030 02:26:01.063803 1 spoke_token_controller.go:432] secret namespace not matched, appAddonNS= open-cluster-management-agent-addon
I1030 02:26:01.325161 1 spoke_token_controller.go:432] secret namespace not matched, appAddonNS= open-cluster-management-agent-addon
--- SNAP ---