Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy auto gen file that is no longer in use #60

Merged

Conversation

dhaiducek
Copy link
Member

@dhaiducek dhaiducek commented Dec 20, 2021

@dhaiducek dhaiducek changed the title emove legacy auto gen file that is no longer in use Remove legacy auto gen file that is no longer in use Dec 20, 2021
@dhaiducek
Copy link
Member Author

This should hopefully fix GRC packages trying to pull in the PlacementRule:

# open-cluster-management.io/multicloud-operators-subscription/pkg/apis/apps/placementrule/v1
Error: /go/pkg/mod/open-cluster-management.io/multicloud-operators-subscription@v0.5.0/pkg/apis/apps/placementrule/v1/zz_generated.openapi.go:34:3: cannot use "github.com/go-openapi/spec".Schema{...} (type "github.com/go-openapi/spec".Schema) as type "k8s.io/kube-openapi/pkg/validation/spec".Schema in field value
Error: /go/pkg/mod/open-cluster-management.io/multicloud-operators-subscription@v0.5.0/pkg/apis/apps/placementrule/v1/zz_generated.openapi.go:55:8: cannot use ref("k8s.io/apimachinery/pkg/apis/meta/v1.ObjectMeta") (type "k8s.io/kube-openapi/pkg/validation/spec".Ref) as type "github.com/go-openapi/spec".Ref in field value
Error: /go/pkg/mod/open-cluster-management.io/multicloud-operators-subscription@v0.5.0/pkg/apis/apps/placementrule/v1/zz_generated.openapi.go:60:8: cannot use ref("open-cluster-management.io/multicloud-operators-subscription/pkg/api...) (type "k8s.io/kube-openapi/pkg/validation/spec".Ref) as type "github.com/go-openapi/spec".Ref in field value
Error: /go/pkg/mod/open-cluster-management.io/multicloud-operators-subscription@v0.5.0/pkg/apis/apps/placementrule/v1/zz_generated.openapi.go:65:8: cannot use ref("open-cluster-management.io/multicloud-operators-subscription/pkg/api...) (type "k8s.io/kube-openapi/pkg/validation/spec".Ref) as type "github.com/go-openapi/spec".Ref in field value

https://github.com/open-cluster-management-io/governance-policy-spec-sync/runs/4587483893?check_suite_focus=true#step:8:118-122

@mikeshng
Copy link
Member

fossa scan fix PR #61

Signed-off-by: Dale Haiducek <dhaiduce@redhat.com>
@dhaiducek
Copy link
Member Author

Would someone please re-run these tests? The failure was intermittent as far as I can tell.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 4, 2022
@mikeshng
Copy link
Member

mikeshng commented Jan 4, 2022

Sorry about that we will try to fix the test asap. We think it has to do with GitHub actions performance related. For now lets do just do a few retries and it should go thru.

@openshift-merge-robot openshift-merge-robot merged commit e2e0aa6 into open-cluster-management-io:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants