Show error when Helm subscription failed to find any matching Helm chart. for deployment.

[mikeshng]

Show error when Helm subscription failed to find any matching Helm chart. for deployment.
Fix Hub dryrun by not creating a new manager each time.
Remove duplicated function that came from HelmRelease port to Subscription.

Signed-off-by: Mike Ng <ming@redhat.com>

[xiangjingli]

@mikeshng @rokej The fix looks even better so that we won't need to create a new manager for dry run.

Just noticed this kubeClient is created but no release at the end of the function. wonder if it needs to be released explicitly? Or not like the manager, it will be released automatically as it is local variable in the function.

We may verify this in Roke's env to double check the memory is not growing up.

multicloud-operators-subscription/pkg/controller/mcmhub/metaupdate.go

Line 222 in c7f2905

kubeClient := kube.New(rcg)

[mikeshng]

Hi @xiangjingli Roke has agreed to run another performance test.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikeshng,rokej]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mikeshng]

for #134