fix minor misplacement

[vMaroon]

Signed-off-by: Maroon Ayoub maroon.ayoub@ibm.com

[mikeshng]

/lgtm

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, vMaroon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikeshng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mikeshng]

The lint error is regarding

pkg/utils/gitrepo.go:262: File is not `gofmt`-ed with `-s` (gofmt)

So maybe you didn't use a code editor like Visual Studio Code that automates the source files.
You can run gofmt gitrepo.go and copy the output and recommit and repush.

You can run make lint locally to check if it passes the lint first.

[vMaroon]

@mikeshng my installed linter versions are stricter (e.g.,:

pkg/subscriber/git/git_subscriber.go:108:3: S1002: should omit comparison to bool constant, can be simplified to `*subitem.Subscription.Spec.Placement.HubOfHubsGitOps` (gosimple)
		*subitem.Subscription.Spec.Placement.HubOfHubsGitOps == true {
		^

pkg/controller/mcmhub/mcmhub_controller.go:854:18: `o` can be `k8s.io/klog/v2.KMetadata` (interfacer)
	return value[adjustedPos:]

do I have to reconfigure versions or is it ok not to?

[mikeshng]

It's still just complaining about

golangci/golangci-lint info installed /home/runner/work/multicloud-operators-subscription/multicloud-operators-subscription/go/bin/golangci-lint
pkg/utils/gitrepo.go:262: File is not `gofmt`-ed with `-s` (gofmt)

If all the other tests passed again. I will manually merge this and we will fix it later.
Thank you once again for your contribution.

[mikeshng]

@vMaroon maybe we can try this:
vMaroon#1
Could you please merge my PR to your branch and then we can run the GitHub actions CICD again?
Thanks.

[mikeshng]

/lgtm

Thanks again