-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rework of Reference Hints #1212
Open
mandelsoft
wants to merge
19
commits into
open-component-model:main
Choose a base branch
from
mandelsoft:hints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,195
−485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/feature
new feature, enhancement, improvement, extension
area/documentation
Documentation related
component/ocm-cli
OCM Command Line Interface
kind/dependency
dependency update, etc.
component/ocm-spec
Open Component Model Specification
size/l
Large
labels
Dec 27, 2024
mandelsoft
force-pushed
the
hints
branch
2 times, most recently
from
December 27, 2024 09:33
89d366d
to
1df4ae0
Compare
github-actions
bot
added
the
component/github-actions
Changes on GitHub Actions or within `.github/` directory
label
Dec 27, 2024
mandelsoft
force-pushed
the
hints
branch
2 times, most recently
from
December 27, 2024 09:37
963818b
to
61279df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Documentation related
component/github-actions
Changes on GitHub Actions or within `.github/` directory
component/ocm-cli
OCM Command Line Interface
component/ocm-spec
Open Component Model Specification
kind/dependency
dependency update, etc.
kind/feature
new feature, enhancement, improvement, extension
size/l
Large
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Rework a design flaw with reference hints in access specifications.
see docs/adrs/0003-reference-hints.md](docs/adrs/0003-reference-hints.md #1213
Which issue(s) this PR fixes
Fixes #1213
Incompatible Changes:
Component Version Representation
left as they are. This means, that old versions of the OCM tooling
cannot work correctly with component versions with persisted hints in
access specifications
Those component versions cannot be verified by an older tool version.
OCM Library
The
SetResourceBlob
andSetSourceBlob
API methods now accepta hint specification instead of a string. To be as compatible as possible,
it still accepts a string (as before), which is mapped by a hint parser to a hint list.
Therefore, the technical type is
interface{}
, which acceptsvarious effective types (single hints, string and hint lists).
Uploaders provided by a plugin now get a serialized hint list
instead of a simple untyped reference format.
There are new options for creating resource(source access objects.