Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FAL-2030] Updates kombu package to support multi-tenant redi… #398

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

nizarmah
Copy link

@nizarmah nizarmah commented Sep 13, 2021

…s authentication (#397)"

This reverts commit 04dbfa3.

Description

The reason behind reverting the change is explained here.

In short, the celery workers are timing out, terminating, and restarting whenever used. This is also causing app servers to fail provisioning when attempting to import the demo course.

Testing instructions

  • Provision an app server for an instance using opencraft-release/koa.3. Make sure it has the 04dbfa3.
    The app server should fail to provision by timing out at TASK [demo : import demo course].
  • Provision a new app server for the same instance using nizar/revert-fal-2030.
    The app server should successfully provision.

@nizarmah nizarmah requested a review from jvdm September 13, 2021 17:49
Copy link

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Verified server's configuration and healthcheck, all green.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.` N/A

@nizarmah nizarmah merged commit 9f57dc7 into opencraft-release/koa.3 Sep 13, 2021
@nizarmah nizarmah deleted the nizar/revert-fal-2030 branch September 13, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants