Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SE-4631] feat: add CCX ID to generated filename prefixes (#27028) #438

Merged

Conversation

gabor-boros
Copy link
Member

@gabor-boros gabor-boros commented Nov 1, 2021

This is the backport of https://github.com/edx/edx-platform/pull/27028.


This pull requests backport a feature to include CCX course IDs in the generated course filenames used for downloading reports, etc.

The suffix appended to the generated filename prefix is following the <separator>_ccx_<ccx id> pattern, to ensure unique filename generation per ccx - previously all CCX courses were downloaded with the same name.

Dependencies: None

Screenshots:
Screenshot 2021-03-16 at 16 22 12

Sandbox URL: TBD

Merge deadline: None

Testing instructions:

  1. Navigate to https://pr29101.sandbox.opencraft.hosting
  2. Login as staff
  3. Navigate to https://pr29101.sandbox.opencraft.hosting/courses/ccx-v1:edX+DemoX+Demo_Course+ccx@1/instructor#view-data_download
  4. Click "Download profile information as a CSV" button
  5. Check that the file name contains CCX

Copy link
Member

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: verified that the required ccx prefix is added to the filename as described in the testing instructions
  • I read through the code
  • I checked for accessibility N/A
  • Incudes documentation N/A

@gabor-boros gabor-boros merged commit d9822e3 into opencraft-release/lilac.2 Nov 8, 2021
@gabor-boros gabor-boros deleted the gabor/cherry-pick-ccx-filename-lilac2 branch November 8, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants