Skip to content

Commit

Permalink
fix(pd): service-std filter;
Browse files Browse the repository at this point in the history
- Catch for no `performance`.
  • Loading branch information
JVickery-TBS committed Oct 10, 2024
1 parent 9567280 commit caa4a84
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bin/filter/filter_service_std.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ def main():
if row['target']:
target = float(row['target'])

# if no total_volume then target_met is not possible
if den <= 0:
# if no performance(volume_meeting_target/total_volume) then target_met is not possible
if row['performance'] is None:
row['target_met'] = 'NA'

# if performance >= target then target is met
Expand Down
1 change: 1 addition & 0 deletions changes/0009.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed an issue with the Standard Service filter script not handling null `performance` fields.

0 comments on commit caa4a84

Please sign in to comment.