Update wet theme #1012
Update wet theme #1012
Conversation
|
Yeah we don't want staging merged into this branch. Would you like to reset to the commit before the merge or should I? |
|
Also please make the PR against master instead of staging |
wardi
force-pushed
the
update-wet-theme
branch
from
2d183f7 to
0074244
Compare
|
@HoussamBedja I force-pushed to remove the merge from staging, please reset the branch on your repo to the same commit before adding any more changes |
|
Also the README needs to be updated for the new WET installation steps. |
|
@HoussamBedja thanks, would you add instructions for installing the necessary files for WET as well? There were some instructions in the ckanext-wet-boew readme you can start from |
|
@wardi I added instructions to install the wet files. Please let me know if you have any feedback |
|
Oh true, the GCWeb version number is changed. The --strip-components option is the same. |
|
Are you sure? The last time I installed the gcweb package it had no "GCWeb" subdirectory because I used the "cdn" version https://github.com/wet-boew/GCWeb/releases/download/v5.1/themes-cdn-5.1-gcweb.zip should I have used the dist version instead? |
|
Hmm maybe I'm not sure. I just tested these commands and they give the desired output (a GCWeb directory containing the theme files as direct children, with no subdirectory) |
…xt-canada into update-wet-theme
Hi Ian,
Could you please review this pull request then deploy it to staging?
This branch already includes the changes that you previously reviewed in the "add-wet-theme" + the update to WET v5 on both portal and registry sites.
Before this pull request, I was asked by Ross to first merge commits from the master branch then also from staging branch, which is why you will find lots of changes added that are not made by me, but from what was already existing in master.
I am trying to have it up on staging as soon as possible for the business team to test both sites (and will work on cleaning up unused code in parallel next week).
Thanks!