add title to truncated links #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVickery-TBS
requested changes
Aug 21, 2024
wardi
reviewed
Aug 23, 2024
| @@ -31,6 +31,11 @@ | |||
| {% endif %} | |||
| {% endblock %} | |||
|
|
|||
| {% block breadcrumb_content %} | |||
| {{ super.super() }} | |||
| <li class="active"><a href="" title="{{ h.resource_display_name(res) }}">{{ h.resource_display_name(res)|truncate(80) }}</a></li> | |||
There was a problem hiding this comment.
AFAIK <a> tags without an href are bad for a11y. Are we allowed to add a title to another type of tag?
There was a problem hiding this comment.
I think you can do javascript void into the href to fix the a11y complaints.
There was a problem hiding this comment.
Also put tabindex="-1" to prevent tabbing
wardi
reviewed
Aug 23, 2024
JVickery-TBS
approved these changes
Aug 26, 2024
wardi
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.