Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wider null check for giftCrateTemplate #267

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

yoganlava
Copy link
Contributor

giftCrateTemplate can undefined and is checked if it === null.
This is not true, this commit uses a better null check.

Hopefully closes #260

Summary

Describe your changes here. Remove any inapplicable sections.

Server changes (config/, server/, worker/, etc.):

  • Better null check for giftCrateTemplate

Testing

Have you tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

giftCrateTemplate can undefined and is checked if it === null.
This is not true, this commit uses a better null check.
@yoganlava yoganlava changed the title Stricter wider null check for giftCrateTemplate Wider null check for giftCrateTemplate Jan 16, 2023
@willroberts willroberts merged commit b46ceb6 into open-duelyst:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P2] Cannot read property 'availableAt' of undefined
2 participants