Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty deck before importing #269

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

yoganlava
Copy link
Contributor

Summary

Empty deck before importing

Closes #255

App changes (app/, etc.):

  • Empties deck before importing

Testing

Have you have tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

Empties the deck before importing to ensure no extra cards are added
@yoganlava yoganlava changed the title Dev decklist import Empty deck before importing Jan 17, 2023
@willroberts willroberts merged commit c31def8 into open-duelyst:main Jan 17, 2023
@willroberts
Copy link
Collaborator

Thanks!

Feel free to send me your Discord handle so I can give you the contributor role in the OpenDuelyst server.

@yoganlava
Copy link
Contributor Author

Sure it's Lava#1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P0] Importing a decklist doesnt delete your previous deck/general. Many bugs happen as a result.
2 participants