Remove agl folder

[ThePixelGamer]

This PR removes the agl folder, fixes include inconsistencies and adds a proper ordering for the includes.
Currently that looks like this:

• regular <> includes
• nn/nvn/vapours (folders from NintendoSDK)
• files that start with sead
• regular "" includes

---

This change is 

[MonsterDruide1]

Should this also get a fully qualified name, or stay like this? What about the ordering in such a case?

[ThePixelGamer]

I personally prefer the styling of not using folders when pulling files from the same folder but if leo wants I can change to include the common/ for consistency

[MonsterDruide1]

Reviewed 64 of 64 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @leoetlino and @ThePixelGamer)

---

.clang-format line 40 at r1 (raw file):

    Priority:        3
  - Regex:           '^<'
    Priority:        1

Order it according to priority in here as well?

Code quote:

  - Regex:           '^<'
    Priority:        1

---

include/common/aglRenderTarget.h line 3 at r1 (raw file):

#pragma once

#include "aglTextureData.h"

Same here - including a path, maybe?

---

include/texture/aglTextureDataSerializer.h line 13 at r1 (raw file):

};

}  // namespace agl

Oh, look - a missing newline at the end of the file! If we're touching nearly every file here, fix that?

[ThePixelGamer]

Order it according to priority in here as well?

  - Regex:           '^<'
    Priority:        1

nada in this case the sead files will be grouped with this regex if it's at the top (at least from my testing but I might've done something wrong?)

[ThePixelGamer]

include/texture/aglTextureDataSerializer.h line 13 at r1 (raw file):

Previously, MonsterDruide1 wrote…

Oh, look - a missing newline at the end of the file! If we're touching nearly every file here, fix that?

Done.

[ThePixelGamer]

Dismissed @MonsterDruide1 from a discussion.
Reviewable status: 59 of 64 files reviewed, 3 unresolved discussions (waiting on @leoetlino and @MonsterDruide1)

[MonsterDruide1]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @leoetlino and @ThePixelGamer)

---

.clang-format line 40 at r1 (raw file):

Previously, MonsterDruide1 wrote…

Order it according to priority in here as well?

Oh, good point. Nevermind then.

[aboood40091]

Please use <> for includes not in the same folder. Also, the folders need renaming. Are you going to do that in a separate PR?

[ThePixelGamer]

Which folders need renaming? If you could send it in the discord

[ThePixelGamer]

Fixed and waiting for leo's input for the <> suggestion

[MonsterDruide1]

Reviewed 32 of 32 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @leoetlino and @ThePixelGamer)

---

src/utility/aglParameterStringMgr.cpp line 9 at r3 (raw file):

ParameterStringMgr::ParameterStringMgr() {
#ifdef SEAD_DEBUG
    setNodeName("utility::ParameterStringMgr");

Was this an intended change?

[ThePixelGamer]

Oops, was abusing vscode's replace feature

[ThePixelGamer]

src/utility/aglParameterStringMgr.cpp line 9 at r3 (raw file):

Previously, MonsterDruide1 wrote…

Was this an intended change?

Done.

[MonsterDruide1]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @leoetlino, @MonsterDruide1, and @ThePixelGamer)

[MonsterDruide1]

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @leoetlino)