Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utl: Add aglDevTools.h #14

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

MonsterDruide1
Copy link
Contributor

@MonsterDruide1 MonsterDruide1 commented Feb 27, 2023

This whole thing can either be a class with static functions, or a namespace - according to mangling rules and tests with godbolt. I would think that a class makes a bit more sense, as genMessage(context) seems to be a common function for agl-classes. The getter/setter functions themselves seem to write to static variables, and there are no constructors or instances of DevTools ever kept in a different class.

The functions were "generated" by copying all lines from the function list in IDA, then iteratively adjusting them using Regex to produce functional C-code, as well as conforming our style rules. Return types were manually added whenever it made sense to do so.


This change is Reviewable

@ThePixelGamer
Copy link
Contributor

Rebase needed

@ThePixelGamer
Copy link
Contributor

LGTM :shipit:

@ThePixelGamer ThePixelGamer merged commit 1e15224 into open-ead:master Mar 3, 2023
@MonsterDruide1 MonsterDruide1 deleted the devtools branch March 8, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants