-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: Copy aglRes-Files from WiiU-Decomp #15
Conversation
a61f864
to
d7ea8dd
Compare
d7ea8dd
to
77bf493
Compare
IIRC the format changed slightly since NSMBU. You might want to double-check if there are any differences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably missed some things but some more research needs to be done
The assertions can be uncommented - you might need to include sead's assert header first though. |
What files/classes can be looked at here? Searching for |
LGTM other than that, thanks for porting these changes over! |
bd16456
to
aaae4cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need @leoetlino's approval of the non-matching functions in aglResShaderArchive.cpp
, the reason for their inclusion being:
#15 (comment)
If he doesn't reply in the upcoming few days, we can merge this ig.
No response yet, so should we merge without approval, or wait for longer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (other than some modernisation nits, e.g. xxxxx::iterator
could be replaced with auto
), sorry for the late review
Due to the amount of stuff needed to get properly defined classes in #13, this has been moved to a separate PR.
This Pull Request mainly copies the files from https://github.com/aboood40091/sead/tree/master/packages/agl/include/common required to add
ResShaderArchive
andResShaderBinaryArchive
, with minimal changes (formatting to align with our custom guidelines).This change is