RFC: Projection Libraries #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This is not complete and not all of these match, but it's a good start on the process.
|
All projections must be in the same header/cpp file. |
added 3 commits
June 14, 2023 18:33
| @@ -63,6 +63,6 @@ class GraphicsNvn : public Graphics | |||
| bool _201; | |||
| bool _202; | |||
| }; | |||
| static_assert(sizeof(GraphicsNvn) == 0x208); | |||
| // static_assert(sizeof(GraphicsNvn) == 0x208); | |||
There was a problem hiding this comment.
is there a reason why this was commented out?
| } // namespace sead | ||
|
|
||
| #endif // SEAD_GRAPHICS_CONTEXT_H_ | ||
| #ifndef SEAD_GRAPHICS_CONTEXT_H_ |
There was a problem hiding this comment.
extra copy and paste?
| @@ -0,0 +1,550 @@ | |||
| #ifndef SEAD_GRAPHICS_CONTEXT_H_ | |||
| @@ -1,31 +1,35 @@ | |||
| #pragma once | |||
| #ifndef SEAD_VIEWPORT_H_ | |||
| explicit Viewport(const BoundBox2f& parent); | ||
| explicit Viewport(const LogicalFrameBuffer& buffer); | ||
| Viewport(f32 left, f32 top, f32 sizeX, f32 sizeY); | ||
| // explicit Viewport(const BoundBox2f& box); |
There was a problem hiding this comment.
reason behind commenting this out?
| @@ -22,8 +22,6 @@ s32 DirectResource::getLoadDataAlignment() const | |||
| return 4; | |||
| } | |||
|
|
|||
| void DirectResource::doCreate_(u8*, u32, Heap*) {} | |||
There was a problem hiding this comment.
this change seems unrelated to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement many of the Projection libraries and tries to update their dependencies where needed and from @aboood40091's repo.
Goals
Projectionlibraries, including what appear to be the Perspective, Ortho, Frustum, and Direct projections.Addresses
0xB1D898-0xB1F2B0are the bulk of the Projection functions in BotW.0xB1FFF0-0xB20718are thesead::ViewportfunctionsWaiting on dependencies
Projection::unproject(Ray<>, ...)Non-Matching Functions
Projection::doScreenPosToCameraPosTo(sead::Vector3<float>*, sead::Vector3<float> const&) constProjection::project(sead::Vector2<float>*, sead::Vector3<float> const&, sead::Viewport const&) constProjection::unproject(sead::Vector3<float>*, sead::Vector3<float> const&, sead::Camera const&) constProjection::doUpdateDeviceMatrix(sead::Matrix44<float>*, sead::Matrix44<float> const&, sead::Graphics::DevicePosture) constPerspectiveProjection::PerspectiveProjection()PerspectiveProjection::PerspectiveProjection(float, float, float, float)OrthoProjection::OrthoProjection()OrthoProjection::OrthoProjection(float, float, float, float, float, float)OrthoProjection::OrthoProjection(float, float, sead::Viewport const&)OrthoProjection::setByViewport(sead::Viewport const&)OrthoProjection::doUpdateMatrix(sead::Matrix44<float>*) constFrustumProjection::FrustumProjection(float, float, float, float, float, float)DirectProjection::DirectProjection()DirectProjection::DirectProjection(sead::Matrix44<float> const*, sead::Graphics::DevicePosture)DirectProjection::setDirectProjectionMatrix(sead::Matrix44<float> const*, sead::Graphics::DevicePosture)DirectProjection::updateAttributesForDirectProjection()DirectProjection::doUpdateMatrix(sead::Matrix44<float>*) constDirectProjection::doScreenPosToCameraPosTo(sead::Vector3<float>*, sead::Vector3<float> const&) constNext Steps
I'm looking for feedback on the non-matching functions, and which of the library files that have been modified that need to be updated here.
This change is