Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reproducible workflow strategy compatible with soft-fork #19

Merged
merged 14 commits into from
Nov 12, 2024

Conversation

tgilon
Copy link

@tgilon tgilon commented Oct 28, 2024

Closes open-energy-transition/cookiecutter-project#2.

Changes proposed in this Pull Request

To make the soft-fork strategy compatible with the concepts of the cookiecutter, it is suggested that the necessary files be included in the main repository. With this structure it should be easy to kick out projects as soft-forks.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@tgilon tgilon marked this pull request as ready for review October 28, 2024 09:49
@tgilon
Copy link
Author

tgilon commented Oct 28, 2024

@siddharth-krishna @daniel-rdt @yerbol-akhmetov As discussed last week, here is the PR. Your feedback is welcome !

@tgilon tgilon self-assigned this Oct 28, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Thomas! This is a nice idea. I've left some minor comments. I'm also wondering if the first paragraph should say something about the soft fork strategy and link to the handbook?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tgilon tgilon requested a review from martacki October 28, 2024 12:25
@tgilon
Copy link
Author

tgilon commented Oct 28, 2024

Thanks, Thomas! This is a nice idea. I've left some minor comments. I'm also wondering if the first paragraph should say something about the soft fork strategy and link to the handbook?

@siddharth-krishna I've added a new paragraph in the README.

@tgilon
Copy link
Author

tgilon commented Oct 30, 2024

@pz-max I've updated the default licence to MIT. @martacki Do you have any other suggestions ?

@tgilon tgilon changed the title Add a reproducible workflow strategy compatbile with soft-fork Add a reproducible workflow strategy compatible with soft-fork Oct 31, 2024
@tgilon tgilon force-pushed the feature/reproducible-workflow branch from ccada57 to 3b72e5c Compare November 12, 2024 13:55
@tgilon tgilon merged commit 89a9d07 into master Nov 12, 2024
@tgilon tgilon deleted the feature/reproducible-workflow branch November 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make this template compatible with OET's soft fork strategy
3 participants