Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force a republish #298

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: force a republish #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/OpenFeature.Contrib.Providers.Flipt/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The flipt provider allows you to connect to your Flipt instance through the Open

## Install dependencies

The first things we will do is install the **Open Feature SDK** and the **Flipt Feature Flag provider**.
The first thing we will do is install the **OpenFeature SDK** and the **Flipt Feature Flag provider**.

### .NET Cli

Expand Down Expand Up @@ -48,7 +48,7 @@ packet add OpenFeature.Contrib.Providers.Flipt

## Using the Flipt Provider with the OpenFeature SDK

To create a Flipt provider you should define provider and pass in the instance `url` (required), `defaultNamespace` and
To create a Flipt provider, you should define the provider and pass in the instance `url` (required), `defaultNamespace` and
`token`.

```csharp
Expand Down Expand Up @@ -129,6 +129,6 @@ nswag openapi2csclient /className:FliptRestClient /namespace:Flipt.Rest /input:"

-In `BuildClient()` method
from https://github.com/open-feature/dotnet-sdk-contrib/blob/204144f6df0dacf46e6d52d34dd6b5a223a853f4/src/OpenFeature.Contrib.Providers.Flipt/ClientWrapper/FliptClientWrapper.cs#L41-L47
a new `HttpClient` is created. In the future it would be better to allow passing of `HttpConnectionFactory` to avoid
a new `HttpClient` is created. In the future, it would be better to allow passing of `HttpConnectionFactory` to avoid
problems regarding socket starvation