test: Remove Moq #79
Merged
test: Remove Moq #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
toddbaert
reviewed
Sep 5, 2023
toddbaert
reviewed
Sep 5, 2023
| @@ -29,7 +29,7 @@ | |||
| </PackageReference> | |||
| <PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVer)" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkPkgVer)" /> | |||
| <PackageReference Include="Moq" Version="$(MoqVer)" /> | |||
| <PackageReference Include="NSubstitute" Version="$(NSubstituteVer)" /> | |||
thomaspoignant
approved these changes
Sep 6, 2023
bacherfl
approved these changes
Sep 6, 2023
|
Thanks a lot @askpt ! |
vpetrusevici
pushed a commit
to vpetrusevici/open-feature-dotnet-sdk-contrib
that referenced
this pull request
Oct 18, 2023
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR Removes Moq and uses NSubstitute instead.
Related Issues
Fixes #76
Notes
Deleted HttpClientMock.cs. This class is not used anymore.
Follow-up Tasks
No need for follow-up tasks.
How to test
Should pass the CI.