-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove Moq #79
test: Remove Moq #79
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ctrl+f "moq" returns no results, and the tests make sense.
Unrelated - I did notice in this PR that we need to add folders under test/
to our component owners config. Opened: #81
@@ -29,7 +29,7 @@ | |||
</PackageReference> | |||
<PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVer)" /> | |||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkPkgVer)" /> | |||
<PackageReference Include="Moq" Version="$(MoqVer)" /> | |||
<PackageReference Include="NSubstitute" Version="$(NSubstituteVer)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Thanks a lot @askpt ! |
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
This PR
This PR Removes Moq and uses NSubstitute instead.
Related Issues
Fixes #76
Notes
Deleted HttpClientMock.cs. This class is not used anymore.
Follow-up Tasks
No need for follow-up tasks.
How to test
Should pass the CI.