Skip to content

Commit

Permalink
chore(deps): Project file cleanup and remove unnecessary dependencies (
Browse files Browse the repository at this point in the history
…#251)

## This PR

- simplify the `InternalsVisibleTo` usage
- cleanup msbuild condition
- remove unnecessary dependencies

---------

Signed-off-by: Weihan Li <weihanli@outlook.com>
Co-authored-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
  • Loading branch information
WeihanLi and benjiro authored Mar 28, 2024
1 parent ab34c16 commit 79def47
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 13 deletions.
4 changes: 2 additions & 2 deletions build/Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="System.Threading.Channels" />
<PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
<PackageReference Include="System.Threading.Channels" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
</ItemGroup>

<ItemGroup Condition="'$(OS)' == 'Unix'">
Expand Down
15 changes: 4 additions & 11 deletions src/OpenFeature/OpenFeature.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462'" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>OpenFeature.Benchmarks</_Parameter1>
</AssemblyAttribute>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>OpenFeature.Tests</_Parameter1>
</AssemblyAttribute>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>OpenFeature.E2ETests</_Parameter1>
</AssemblyAttribute>
<InternalsVisibleTo Include="OpenFeature.Benchmarks" />
<InternalsVisibleTo Include="OpenFeature.Tests" />
<InternalsVisibleTo Include="OpenFeature.E2ETests" />
<None Include="../../README.md" Pack="true" PackagePath="/" />
</ItemGroup>

Expand Down

0 comments on commit 79def47

Please sign in to comment.