Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Default Logging Hook #308

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kylejuliandev
Copy link

Work in progress, if anyone has some initial feedback it would be greatly appreciated!

This PR

  • Adds in default Logging Hook

Related Issues

Fixes #299

Notes

Follow-up Tasks

How to test

@beeme1mr
Copy link
Member

beeme1mr commented Oct 9, 2024

Hey @kylejuliandev, thanks for the PR. Could you please sign off your commits? The CNCF requires you to acknowledge that you're willing and able to donate this code.

To add your Signed-off-by line to every commit in this branch:

Thanks!

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
…th string.IsNullOrEmpty

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
@kylejuliandev
Copy link
Author

Hi @beeme1mr!

No worries, I've pushed up the signed commits now. Happy to donate this code, although it is incomplete at the moment. Will resume and get some unit tests in. Logging semantics (log IDs, log levels, content, etc...) are still left to determine - although I have tried to adhere to the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Logging Hook
2 participants