-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flagd OTEL collector #586
Merged
Kavindu-Dodan
merged 9 commits into
open-feature:main
from
Kavindu-Dodan:feat/otel-collector
Apr 10, 2023
Merged
feat: flagd OTEL collector #586
Kavindu-Dodan
merged 9 commits into
open-feature:main
from
Kavindu-Dodan:feat/otel-collector
Apr 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
feat/otel-collector
branch
from
April 4, 2023 22:38
3de18fc
to
6c96b87
Compare
Kavindu-Dodan
commented
Apr 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 70.91% 70.77% -0.15%
==========================================
Files 21 22 +1
Lines 2187 2248 +61
==========================================
+ Hits 1551 1591 +40
- Misses 577 592 +15
- Partials 59 65 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thisthat
reviewed
Apr 5, 2023
Kavindu-Dodan
force-pushed
the
feat/otel-collector
branch
from
April 5, 2023 18:11
dc76b3e
to
9eb6bc3
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/otel-collector
branch
from
April 5, 2023 20:47
35b6c5b
to
c9aba7f
Compare
Kavindu-Dodan
requested review from
beeme1mr,
toddbaert,
james-milligan and
odubajDT
April 5, 2023 21:02
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
bacherfl
reviewed
Apr 6, 2023
bacherfl
reviewed
Apr 6, 2023
thisthat
approved these changes
Apr 6, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Kavindu-Dodan
force-pushed
the
feat/otel-collector
branch
from
April 6, 2023 17:51
e98d560
to
301e74f
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/otel-collector
branch
from
April 6, 2023 17:54
301e74f
to
64f08ec
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
bacherfl
approved these changes
Apr 7, 2023
toddbaert
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #563
Introduce configurations for flagd to connect to OTEL collector. Also, improves how telemetry configurations are handled.
Changes include,
Package renaming - otel to telemetry - This avoids import conflicts
Introduce a telemetry builder - The intention is to have a central location to handle telemetry configurations and build telemetry components
Introduce a span processor builder - Provide groundwork for OTel Traces for evaluation in flagd #575 (needs fallback mechanism)
How to test?
Consider following this guide - (doc generated from commit) https://github.com/open-feature/flagd/blob/81c66b3c89540b475fe0a46ac89869800f7b74ae/docs/configuration/flagd_telemetry.md
In short,
flagd start --uri file:/flags.json --metrics-exporter otel --otel-collector-target localhost:4317
)Metrics will be available at Prometheus(http://localhost:9090/graph). Traces are still missing as we have to implement them.