Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configcat-provider): Add ConfigCat provider #242

Merged
merged 14 commits into from
Jun 19, 2023

Conversation

rcrowe
Copy link
Contributor

@rcrowe rcrowe commented Jun 14, 2023

This PR

Related Issues

N/A

Notes

Community contribution working with @z4kn4fein the author of the ConfigCat Go SDK.

Follow-up Tasks

N/A

How to test

  • Standard Go tests
  • make test from repo root

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
@rcrowe rcrowe marked this pull request as ready for review June 14, 2023 16:11
@rcrowe rcrowe requested a review from a team as a code owner June 14, 2023 16:11
rcrowe added 10 commits June 14, 2023 17:18
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Fix feature not available <1.18

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
@@ -0,0 +1,14 @@
module github.com/open-feature/go-sdk-contrib/providers/configcat

go 1.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - I hope this is to be compatible with configcat go-sdk v7 and to support old platforms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct I noticed a comment from you that seemed to suggest it was best to align with the underlying SDK.

Should this instead align with go1.18 from the go-sdk?

Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Provider implementation as well as tests are nicely done. Thank you for the contribution for OpenFeature 🤝

Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
@rcrowe
Copy link
Contributor Author

rcrowe commented Jun 19, 2023

Thank you @Kavindu-Dodan for your help reviewing this.

Do you know what release schedule this project works too, so we can get this merged & a tagged release?

@Kavindu-Dodan
Copy link
Contributor

Thank you @Kavindu-Dodan for your help reviewing this.

Do you know what release schedule this project works to, so we can get this merged & a tagged release?

Welcome. I am waiting for at least one more review and then we can move ahead and merge this.

And as soon as we merge this, release please will create a release PR (for example - [1])

[1] - #216

@beeme1mr beeme1mr requested a review from toddbaert June 19, 2023 16:10
@Kavindu-Dodan Kavindu-Dodan merged commit 1c9cdc6 into open-feature:main Jun 19, 2023
@rcrowe rcrowe deleted the configcat-provider branch June 19, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants