-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configcat-provider): Add ConfigCat provider #242
Conversation
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
2c067b5
to
79a45e1
Compare
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Fix feature not available <1.18 Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
6ba8a11
to
be164fc
Compare
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
@@ -0,0 +1,14 @@ | |||
module github.com/open-feature/go-sdk-contrib/providers/configcat | |||
|
|||
go 1.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor - I hope this is to be compatible with configcat go-sdk v7 and to support old platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct I noticed a comment from you that seemed to suggest it was best to align with the underlying SDK.
Should this instead align with go1.18 from the go-sdk
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Provider implementation as well as tests are nicely done. Thank you for the contribution for OpenFeature 🤝
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
Thank you @Kavindu-Dodan for your help reviewing this. Do you know what release schedule this project works too, so we can get this merged & a tagged release? |
Welcome. I am waiting for at least one more review and then we can move ahead and merge this. And as soon as we merge this, release please will create a release PR (for example - [1]) [1] - #216 |
This PR
Related Issues
N/A
Notes
Community contribution working with @z4kn4fein the author of the ConfigCat Go SDK.
Follow-up Tasks
N/A
How to test
make test
from repo root