fix: nil client causes panic #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Liva <this_that@hotmail.it>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
toddbaert
reviewed
Dec 14, 2023
| func (p *Provider) setStatus(status of.State) { | ||
| p.mtx.Lock() | ||
| defer p.mtx.Unlock() | ||
| p.status = status |
There was a problem hiding this comment.
I would assume this is atomic and therefore locking doesn't help? 🤔
There was a problem hiding this comment.
Oh, this might be needed actually, to prevent interleaving threads checking it during init.
I think I thread isn't blocked by a lock it already owns, right? So I guess you might want to lock in Init() and well as here.
There was a problem hiding this comment.
I think we do need it, yes - if you execute the tests with the -race flag enabled, a data race error occurs, due to p.status being set in the goroutine created within the Init() function, while being accessed via the Status() function in the test
toddbaert
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
related to: open-feature/go-sdk#238