-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Prefab provider #575
Conversation
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liran2000 I left a couple notes but overall this LGTM and (once I got the provider set up properly) works as intended.
Thanks for your efforts here! 💙
Signed-off-by: liran2000 <liran2000@gmail.com>
…contrib into feature/prefab
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
// TODO | ||
// t.Run("sample_json", func(t *testing.T) { | ||
// value, err := ofClient.ObjectValueDetails(context.Background(), "sample_json", map[string]interface{}{ | ||
// "nested": "value", | ||
// }, evalCtx) | ||
// require.Equal(t, []string{"a", "b"}, value.Value) | ||
// require.Nil(t, err) | ||
// }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, can leave it for now, and will track to see when can be enhanced with the additional tests.
// EnvironmentNames []string | ||
// ProjectEnvID int64 | ||
// InitializationTimeoutSeconds float64 | ||
// OnInitializationFailure OnInitializationFailure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed or is there a reason to keep it? Perhaps comment a TODO if so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a component_owners entry for this with yourself and @semanticart if they agree?
Approved otherwise. Thanks!
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
@semanticart added you as well :) thanks ! |
Readme describes the provider.