Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic module names to all packages #261

Closed
toddbaert opened this issue Mar 28, 2023 · 1 comment · Fixed by #407
Closed

Add automatic module names to all packages #261

toddbaert opened this issue Mar 28, 2023 · 1 comment · Fixed by #407
Assignees
Labels
good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

See here, and the linked issue for details and background. This blog post is also helpful, specifically for library maintainers.

In each module in this project, we should add this maven step (we could also add it in the parent POM and somehow grab the name dynamically). We should be careful that the module name matches the "highest level" package in the module.

@Kavindu-Dodan
Copy link
Collaborator

We should be able to utilize existing POM properties to derive unique names and make it a recommendation to add this to POM. And naming could be recommended to derive from existing values. For example,

<properties>
    <module-name>${parent.groupId}.${name}</module-name>
</properties>

flagd provider will result in - dev.openfeature.contrib.flagd

[1] - open-feature/java-sdk#363 (comment)

@Kavindu-Dodan Kavindu-Dodan added the good first issue Good for newcomers label May 25, 2023
@toddbaert toddbaert self-assigned this Aug 23, 2023
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this issue Apr 29, 2024
…ure#261)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants