Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate automatic module names #407

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Aug 23, 2023

See title.

Tested this locally with mvn install, then opened the locally cached module. This is what the MANIFEST.MF looks like for the flagd provider:

Manifest-Version: 1.0
Automatic-Module-Name: dev.openfeature.contrib.providers.flagd
Build-Jdk-Spec: 1.8
Created-By: Maven JAR Plugin 3.3.0

Note: I had to "make up" some module names for a few providers that would otherwise have invalid ones based on the module name (apparently "-" is illegal).

⚠️ Note: http://branchandbound.net/blog/java/2017/12/automatic-module-name/ and https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html strongly recommend that module names should match the root package of the jar. I've therefore used the root package for the "-" cases.

Fixes: #261

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from a team as a code owner August 23, 2023 15:17
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit f18df0f into main Aug 24, 2023
7 checks passed
@toddbaert toddbaert deleted the chore/auto-module-names branch August 24, 2023 12:24
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
….10 (open-feature#407)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic module names to all packages
6 participants