[flagd] shutting down provider should reset the state. #410
Assignees
Labels
contribfest
A good issue for Contribfest KubeCon EU '24
enhancement
New feature or request
good first issue
Good for newcomers
Comments
Kavindu-Dodan
changed the title
|
@thiyagu06 I also see a potential improvement here. Though the spec 1 doesn't enforce a state change requirement after a shutdown, we can set the status to Feel free to open up a contribution PR on this. Footnotes |
Kavindu-Dodan
added
enhancement
|
Sure. I will work on this. |
|
Hey @thiyagu06 I'm going to unassign this from you for now, since we have an event coming up and KubeCon and it might be a good issue for people to take on. However, if you intend on completing it soon, let me know I will reassign to you. |
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this issue
Apr 29, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@toddbaert , I would like to contribute to this issue. Is it possible to assign it to me? |
|
@mehtasankets Assigned. |
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 18, 2024
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 18, 2024
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 18, 2024
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 18, 2024
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 18, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 19, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 19, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 19, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 19, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
Kavindu-Dodan
pushed a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 19, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
mehtasankets
added a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 20, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
Kavindu-Dodan
pushed a commit
to mehtasankets/java-sdk-contrib
that referenced
this issue
Jun 20, 2024
…re#410) Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
Kavindu-Dodan
pushed a commit
that referenced
this issue
Jun 20, 2024
|
Fixed with #832 . Thank you @mehtasankets for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/open-feature/java-sdk-contrib/blob/main/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java#L56
It's not always guaranteed that
FeatureProvider.shutdown()method is called at the end of application lifecycle. The user can call the shutdown method at any point in time of application lifetime. So it's better to reset the state. may be NOT_READY or new state and publish the event with the new state.The text was updated successfully, but these errors were encountered: