Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flagd caching #168

Merged
merged 9 commits into from
Jan 10, 2023
Merged

feat: flagd caching #168

merged 9 commits into from
Jan 10, 2023

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Dec 16, 2022 •
edited
Loading

This PR

Implements caching of flagd.

Related Issues

Fixes #139

Notes

Follow-up Tasks

How to test

@skyerus skyerus changed the title Issue 139 caching feat!: flagd caching Dec 16, 2022
toddbaert
toddbaert reviewed Dec 21, 2022
View reviewed changes
providers/flagd/pom.xml Outdated Show resolved Hide resolved
toddbaert
toddbaert reviewed Dec 21, 2022
View reviewed changes
providers/flagd/pom.xml Outdated Show resolved Hide resolved
@toddbaert
Copy link
Member

@skyerus I see a ! in the title - is there actually a breaking change here, and if so, could you note it?

@skyerus
Copy link
Contributor Author

skyerus commented Dec 22, 2022

@skyerus I see a ! in the title - is there actually a breaking change here, and if so, could you note it?

The constructors have changed, to anyone using the non-exhaustive constructors (e.g. new FlagdProvider();) this won't be a breaking change. To anyone using the exhaustive constructors they will be forced to make changes to include the new parameters. This could be avoided by sustaining the existing constructors but is this worth the maintenance?

@skyerus skyerus marked this pull request as ready for review December 23, 2022 16:58
@skyerus skyerus requested review from Kavindu-Dodan and toddbaert and removed request for Kavindu-Dodan and toddbaert December 23, 2022 16:58
Kavindu-Dodan
Kavindu-Dodan approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kavindu-Dodan
Copy link
Collaborator

@skyerus I see a ! in the title - is there actually a breaking change here, and if so, could you note it?

The constructors have changed, to anyone using the non-exhaustive constructors (e.g. new FlagdProvider();) this won't be a breaking change. To anyone using the exhaustive constructors they will be forced to make changes to include the new parameters. This could be avoided by sustaining the existing constructors but is this worth the maintenance?

From the changeset, I do not see that we have a breaking change 🤔

We have preserved all public constructors, public FlagdProvider(String socketPath) , public FlagdProvider(String host, int port, boolean tls, String certPath) & public FlagdProvider() . But only have provided overloading options to them. The only breaking change is on the package private constructor, which no one should be using.

@skyerus could you please double check on this from your end ?

otherwise, PR is good to merge :)

@skyerus
Copy link
Contributor Author

skyerus commented Jan 3, 2023

@Kavindu-Dodan you are right, thanks! I've amended the title to not be a breaking change :)

@skyerus skyerus changed the title feat!: flagd caching feat: flagd caching Jan 3, 2023
@skyerus skyerus requested a review from toddbaert January 3, 2023 09:00
@skyerus skyerus mentioned this pull request Jan 3, 2023
Closed
@toddbaert toddbaert self-requested a review January 3, 2023 17:40
toddbaert
toddbaert approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved, but please consider changing this log level.

@skyerus
Copy link
Contributor Author

skyerus commented Jan 4, 2023

Converting to draft to implement eventing changes: open-feature/flagd#241

@skyerus skyerus marked this pull request as draft January 4, 2023 17:50
@skyerus skyerus marked this pull request as ready for review January 6, 2023 17:32
@toddbaert toddbaert self-requested a review January 9, 2023 14:18
toddbaert
toddbaert requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice now that we don't have a test for the cache invalidation. I think we should add that. Please let me know if I'm wrong.

skyerus and others added 9 commits January 10, 2023 09:24
@skyerus
feat!: implement caching of flagd provider
cbf6ed3 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
caching testing & documentation
182e5d9 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus @toddbaert
Update providers/flagd/pom.xml
3459479 
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus @toddbaert
Update providers/flagd/pom.xml
d2cb4e8 
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
amendments from code review
9af472b 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
extracted caching implementation into FlagdCache class. consolidated …
a0350dd 
…cache stores into singular map

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus @toddbaert
Update providers/flagd/src/main/java/dev/openfeature/contrib/provider…
37d64b0 
…s/flagd/EventStreamObserver.java

Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
parse consolidated configuration_change event
2584c0e 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
cache invalidation test & NPE check
7edaef7 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
Copy link
Contributor Author

skyerus commented Jan 10, 2023

I notice now that we don't have a test for the cache invalidation. I think we should add that. Please let me know if I'm wrong.

Great shout! I've added a test for cache invalidation

@skyerus skyerus requested a review from toddbaert January 10, 2023 12:41
@toddbaert toddbaert merged commit 528504f into open-feature:main Jan 10, 2023
@github-actions github-actions bot mentioned this pull request Jan 10, 2023
Merged
@skyerus skyerus deleted the issue-139_caching branch January 10, 2023 16:44
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@github-actions
chore(main): release 1.0.0 (open-feature#168)
5a01ed0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@pbhandari9541 @toddbaert
@github-actions @justinabrahms @renovate @dependabot @step-security-bot @beeme1mr @rgrassian-split @snyk-bot
fix(deps): Spot bug scope change (open-feature#173)
113b5e5 
* chore: add integration tests (open-feature#77)

* chore: add integration tests

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* improve POM spacing

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(main): release dev.openfeature.javasdk 0.2.2 (open-feature#76)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* feat!: errorCode as enum, reason as string (open-feature#80)

* feat!: errorCode as enum, reason as string

- makes errorCode an enum
- makes reason a string
- adds errorMessage to resolution/evaluation details

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: add CODEOWNERS (open-feature#85)

Create CODEOWNERS

refs open-feature/java-sdk#83

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Configure Renovate (open-feature#86)

chore(deps): add renovate.json

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency com.github.spotbugs:spotbugs to v4.7.2 (open-feature#87)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency com.github.spotbugs:spotbugs-maven-plugin to v4.7.2.0 (open-feature#88)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.4.1 (open-feature#90)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.sonatype.plugins:nexus-staging-maven-plugin to v1.6.13 (open-feature#91)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* fix(deps): update junit5 monorepo (open-feature#92)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-pmd-plugin to v3.19.0 (open-feature#97)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* fix(deps): update dependency io.cucumber:cucumber-bom to v7.8.0 (open-feature#100)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.mockito:mockito-core to v4.8.0 (open-feature#99)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update codecov/codecov-action action to v3 (open-feature#102)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-gpg-plugin to v1.6 (open-feature#96)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-source-plugin to v3 (open-feature#105)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.10.1 (open-feature#95)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-gpg-plugin to v3 (open-feature#104)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.2.0 (open-feature#94)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/cache action to v3 (open-feature#101)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.45.1 (open-feature#93)

* chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.45.1

* scope property went away in the latest version

jshiell/checkstyle-idea#525 (comment)

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>

* scope wasn't deleted on the other one

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* refactor!: Change the package name. Everyone knows it's java (or it doesn't matter) (open-feature#111)

* Change the package name. Everyone knows it's java (or it doesn't matter)

Fixes open-feature#82

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Missed 2 strings

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* remove broken flagd import until changes absorbed

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Write perms should be as tightly scoped as possible. (open-feature#107)

* Add a dependabot file to keep deps up to date

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Move write permissions to the specific job, rather than globally

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Run code scanning (slow auto-build) weekly

Signed-off-by: Justin Abrahms <justin@abrah.ms>

Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: fix dependabot pr titles (open-feature#118)

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Bump cucumber-bom from 7.8.0 to 7.8.1 (open-feature#115)

Bump cucumber-bom from 7.8.0 to 7.8.1

Bumps [cucumber-bom](https://github.com/cucumber/cucumber-jvm) from 7.8.0 to 7.8.1.
- [Release notes](https://github.com/cucumber/cucumber-jvm/releases)
- [Changelog](https://github.com/cucumber/cucumber-jvm/blob/main/CHANGELOG.md)
- [Commits](cucumber/cucumber-jvm@v7.8.0...v7.8.1)

---
updated-dependencies:
- dependency-name: io.cucumber:cucumber-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: add SAST scanning (open-feature#108)

* add SAST scanning

Refs open-feature#84

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Java scanning only

Signed-off-by: Justin Abrahms <justin@abrah.ms>

* Try codeql on the normal build to see how much longer it is.

Signed-off-by: Justin Abrahms <justin@abrah.ms>

Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* feat!: use evaluation context interface (open-feature#112)

* POC - use evaluation context interface

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* make .merge non-static

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* improve naming

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* add @OverRide

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* Update src/main/java/dev/openfeature/sdk/EvaluationContext.java

Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>

* Update src/main/java/dev/openfeature/sdk/MutableContext.java

Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>

* address PR feedback

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* feat: Support for generating CycloneDX sboms (open-feature#119)

Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: [StepSecurity] ci: Harden GitHub Actions (open-feature#120)

* [StepSecurity] ci: Harden GitHub Actions in release.yml

* [StepSecurity] ci: Harden GitHub Actions in static-code-scanning.yaml

* [StepSecurity] ci: Harden GitHub Actions in lint-pr.yml

* [StepSecurity] ci: Harden GitHub Actions in merge.yml

* [StepSecurity] ci: Harden GitHub Actions in pullrequest.yml

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: I don't think we use that permission? (open-feature#123)

I don't think we use that permission?

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Document where to find our SBOMs (open-feature#124)

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/cache digest to a3f5edc (open-feature#121)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/setup-java digest to e150063 (open-feature#125)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Remove more perms (open-feature#130)

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.cyclonedx:cyclonedx-maven-plugin to v2.7.1 (open-feature#128)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update github/codeql-action digest to 3d39294 (open-feature#127)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update codecov/codecov-action digest to e0fbd59 (open-feature#126)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Bump actions/checkout from 3.0.2 to 3.1.0 (open-feature#139)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@2541b12...93ea575)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Bump actions/setup-java from e150063ee446b60ce2e35b040e81846da9001576 to a82e6d00200608b0b4c131bc9a89f7349786bd33 (open-feature#140)

chore: Bump actions/setup-java

Bumps [actions/setup-java](https://github.com/actions/setup-java) from e150063ee446b60ce2e35b040e81846da9001576 to a82e6d00200608b0b4c131bc9a89f7349786bd33.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@e150063...a82e6d0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: bump spotbugs-maven-plugin from 4.7.2.0 to 4.7.2.1 (open-feature#136)

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.2.0 to 4.7.2.1.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.2.0...spotbugs-maven-plugin-4.7.2.1)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: exclude component in git tag (open-feature#143)

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update dependency org.cyclonedx:cyclonedx-maven-plugin to v2.7.2 (open-feature#141)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* feat!: add rw locks to client/api, hook accessor name (open-feature#131)

* fix: add read/write locks to client/api

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* dont lock entire evaluation

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* add tests

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* fixup comment

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* fixup pom comment

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* increase lock granularity, imporove tests

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* fix spotbugs

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* remove commented test

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/setup-java digest to 3617c43 (open-feature#132)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update amannn/action-semantic-pull-request digest to b314c1b (open-feature#135)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Remove dependabot. I like renovate better (open-feature#142)

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update amannn/action-semantic-pull-request digest to 7c194c2 (open-feature#144)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update github/codeql-action digest to 44edb7c (open-feature#133)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/checkout digest to 8230315 (open-feature#122)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(main): release 0.3.0 (open-feature#114)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: re-enable integration tests (open-feature#146)

Update test harness and re-enable integration test profile

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/cache digest to 9b0c1fc (open-feature#145)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* fix: merge eval context (open-feature#149)

fix merge eval context

Signed-off-by: Robert Grassian <robert.grassian@split.io>

Signed-off-by: Robert Grassian <robert.grassian@split.io>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(main): release 0.3.1 (open-feature#150)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update github/codeql-action digest to 297ec80 (open-feature#147)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: update test/spec association numbers, badge (open-feature#156)

* chore: update test/spec association numbers

Signed-off-by: Todd Baert <toddbaert@gmail.com>

* chore: update spec tag

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/cache digest to 2b04a41 (open-feature#158)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(security): [Snyk] Security upgrade com.github.spotbugs:spotbugs from 4.7.2 to 4.7.3 (open-feature#157)

fix: pom.xml to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-ORGAPACHECOMMONS-3043138

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Add docs link (open-feature#165)

Signed-off-by: Todd Baert <toddbaert@gmail.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore: Mark project as active. (open-feature#167)

Mark project as active.

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>

Signed-off-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(main): release 1.0.0 (open-feature#168)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* chore(deps): update actions/cache digest to 8bec1e4 (open-feature#159)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

* changes spotbug scope to provided.

Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>
Signed-off-by: Justin Abrahms <jabrahms@ebay.com>
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Robert Grassian <robert.grassian@split.io>
Signed-off-by: Pramesh <p_bhandari@hotmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Step Security Bot <bot@stepsecurity.io>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: Robert Grassian <89157164+rgrassian-split@users.noreply.github.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Bhandari, Pramesh(AWF) <pabhandari@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flagd-provider] add caching
3 participants
@skyerus @toddbaert @Kavindu-Dodan