fix: update provider object eval, T -> Structure

Signed-off-by: Todd Baert <toddbaert@gmail.com>
open-feature · Aug 28, 2022 · 3cf5a6f · 3cf5a6f
1 parent 405e812
commit 3cf5a6f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/src/main/java/dev/openfeature/javasdk/FeatureProvider.java b/src/main/java/dev/openfeature/javasdk/FeatureProvider.java
@@ -25,6 +25,6 @@ ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defaultValu
     ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx,
                                                    FlagEvaluationOptions options);
 
-    <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext,
-                                                  FlagEvaluationOptions options);
+    ProviderEvaluation<Structure> getObjectEvaluation(String key, Structure defaultValue,
+                                                    EvaluationContext invocationContext, FlagEvaluationOptions options);
 }
diff --git a/src/main/java/dev/openfeature/javasdk/NoOpProvider.java b/src/main/java/dev/openfeature/javasdk/NoOpProvider.java
@@ -61,10 +61,10 @@ public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double default
     }
 
     @Override
-    public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue,
+    public ProviderEvaluation<Structure> getObjectEvaluation(String key, Structure defaultValue,
                                                          EvaluationContext invocationContext,
                                                          FlagEvaluationOptions options) {
-        return ProviderEvaluation.<T>builder()
+        return ProviderEvaluation.<Structure>builder()
                 .value(defaultValue)
                 .variant(PASSED_IN_DEFAULT)
                 .reason(Reason.DEFAULT)

diff --git a/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java b/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java
@@ -123,7 +123,7 @@ private <T> ProviderEvaluation<?> createProviderEvaluation(
             case DOUBLE:
                 return provider.getDoubleEvaluation(key, (Double) defaultValue, invocationContext, options);
             case OBJECT:
-                return provider.getObjectEvaluation(key, defaultValue, invocationContext, options);
+                return provider.getObjectEvaluation(key, (Structure) defaultValue, invocationContext, options);
             default:
                 throw new GeneralError("Unknown flag type");
         }

diff --git a/src/test/java/dev/openfeature/javasdk/AlwaysBrokenProvider.java b/src/test/java/dev/openfeature/javasdk/AlwaysBrokenProvider.java
@@ -33,7 +33,7 @@ public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double default
     }
 
     @Override
-    public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
+    public ProviderEvaluation<Structure> getObjectEvaluation(String key, Structure defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
         throw new NotImplementedException("BORK");
     }
 }
diff --git a/src/test/java/dev/openfeature/javasdk/DoSomethingProvider.java b/src/test/java/dev/openfeature/javasdk/DoSomethingProvider.java
@@ -44,9 +44,9 @@ public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double default
     }
 
     @Override
-    public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
+    public ProviderEvaluation<Structure> getObjectEvaluation(String key, Structure defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
         savedContext = invocationContext;
-        return ProviderEvaluation.<T>builder()
+        return ProviderEvaluation.<Structure>builder()
                 .value(null)
                 .build();
     }