Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change fractional custom op from percentage-based to relative weighting. #946

Closed
toddbaert opened this issue Jun 17, 2024 · 0 comments · Fixed by #954
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

Requirements

Currently, the fractional operator in the in-process provider is percentage-based; meaning you must specify the relative distribution of the variants in terms of a percentage. Consistent with flagd, we should change this instead to be a relative weight, meaning that the integers do not need to sum to 100. For example, this fractional:

"fractional": [
          [
            "red",
            25
          ],
          [
            "blue",
            25
          ],
          [
            "green",
            25
          ],
          [
            "grey",
            25
          ]
        ]

Would remain valid, but could also be expressed as:

"fractional": [
          [
            "red",
            1
          ],
          [
            "blue",
            1
          ],
          [
            "green",
            1
          ],
          [
            "grey",
            1
          ]
        ]

See issue and PR in Go/flagd.

@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 17, 2024
aepfli added a commit to open-feature-forking/js-sdk-contrib that referenced this issue Jun 19, 2024
…eighting. open-feature#946

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to open-feature-forking/js-sdk-contrib that referenced this issue Jun 19, 2024
…eighting. open-feature#946

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to open-feature-forking/js-sdk-contrib that referenced this issue Jun 19, 2024
…eighting. open-feature#946

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
toddbaert pushed a commit that referenced this issue Jul 2, 2024
…eighting. #946 (#954)

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to open-feature-forking/js-sdk-contrib that referenced this issue Jul 3, 2024
…eighting. open-feature#946

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
1 participant