feat!: update the otel hook to be spec compliant #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
reviewed
Dec 9, 2022
toddbaert
reviewed
Dec 9, 2022
toddbaert
reviewed
Dec 9, 2022
toddbaert
reviewed
Dec 9, 2022
toddbaert
reviewed
Dec 9, 2022
|
Should we add an optional logger to the constructor? Since all hooks run in the SDK try/catch, we don't need to make sure it's safe, but it could help people in debugging. |
toddbaert
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Approved with comments, please especially consider: #179 (comment)
7 tasks
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Merged
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
🚨 This is a breaking change!🚨
The OpenTelemetry semantic convention specification now includes a section on feature flags. The hook no longer creates a new span but attaches a span event to an existing span.
It also changes the attribute names in the following ways:
flag_key=>keyevaluated_valueis no longer used. A stringified version of the value is used if a variant is available.This PR
Related Issues
Fixes #171
Signed-off-by: Michael Beemer beeme1mr@users.noreply.github.com