add missing tests

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
open-feature · Nov 16, 2023 · 5689770 · 5689770
1 parent 5a92721
commit 5689770
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/apis/core/v1beta1/common/common.go b/apis/core/v1beta1/common/common.go
@@ -48,7 +48,7 @@ func EnvVarKey(prefix string, suffix string) string {
 
 // unique string used to create unique volume mount and file name
 func FeatureFlagConfigurationId(namespace, name string) string {
-	return fmt.Sprintf("%s_%s", namespace, name)
+	return EnvVarKey(namespace, name)
 }
 
 // unique key (and filename) for configMap data

diff --git a/apis/core/v1beta1/common/common_test.go b/apis/core/v1beta1/common/common_test.go
@@ -23,6 +23,14 @@ func Test_FeatureFlagSource_SyncProvider(t *testing.T) {
 	require.False(t, g.IsHttp())
 }
 
-func Test_FLagSourceConfiguration_envVarKey(t *testing.T) {
+func Test_FLagSourceConfiguration_EnvVarKey(t *testing.T) {
 	require.Equal(t, "pre_suf", EnvVarKey("pre", "suf"))
 }
+
+func Test_FLagSourceConfiguration_FeatureFlagConfigurationId(t *testing.T) {
+	require.Equal(t, "pre_suf", FeatureFlagConfigurationId("pre", "suf"))
+}
+
+func Test_FLagSourceConfiguration_FeatureFlagConfigMapKey(t *testing.T) {
+	require.Equal(t, "pre_suf.flagd.json", FeatureFlagConfigMapKey("pre", "suf"))
+}