Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed old prefix from flagd-proxy provider config #463

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

james-milligan
Copy link
Contributor

@james-milligan james-milligan commented Apr 12, 2023

This PR

  • fixed bug caused by using old prefix from flagd-proxy provider config

Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan requested a review from a team as a code owner April 12, 2023 14:52
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #463 (8cb9d10) into main (e0d639a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files          21       21           
  Lines        1365     1365           
=======================================
  Hits         1065     1065           
  Misses        259      259           
  Partials       41       41           
Impacted Files Coverage Δ
webhooks/pod_webhook.go 81.27% <0.00%> (ø)
Flag Coverage Δ
unit-tests 78.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@james-milligan james-milligan merged commit 39a99c6 into open-feature:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants