-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flagd-rpc)!: add events for rpc mode, some breaking config fixes #108
feat(flagd-rpc)!: add events for rpc mode, some breaking config fixes #108
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 93.47% 93.92% +0.45%
==========================================
Files 14 14
Lines 582 675 +93
==========================================
+ Hits 544 634 +90
- Misses 38 41 +3 ☔ View full report in Codecov by Sentry. |
@toddbaert @beeme1mr @open-feature/sdk-python-maintainers please have a look - this is not perfect - and i might made some errors, but i hope this is somewhat going into the right direction |
04a0ff8
to
572dc51
Compare
57b626b
to
5055533
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
relates also to |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
2f89c0b
to
4b74a53
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
5f62c30
to
8b3990f
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
8b3990f
to
9a107c5
Compare
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the e2e running without the event scenario being skipped now! Very nice to have this feature working and the e2e tests for confidence.
I also went through all the breaking config changes and to me they seem in line with the spec (at least those that we've fully implemented).
I've changed the PR title slightly to (IMO) make the release notes a bit clearer.
…rovider/flagd/resolvers/grpc.py Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
b82b626
to
8a794fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding backwards compatiblity with timeout
. The other breaking changes should have virtually no impact because the currently released in-process mode only supported local file watching.
Awesome job! 🥳
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, just one adjustment would be great.
int( | ||
env_or_default( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing you have to fix, but env_or_default()
should return the correct type, when cast
is set. will try to fix it in a separate PR.
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
…rovider/flagd/provider.py Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
192f501
to
cdd9aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beeme1mr feel free to merge when you are ok with your comments.
Adding Events to the RPC client:
Breaking Change
rpc
instead ofgrpc
to be compliant with flagd spectimeout
config value todeadline
, to be compliant with flagd specoffline source path poll interval
as the general approach in other providers is to useretry_backoff_ms
closes: #56