Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce Release Please and PR linting workflows #38

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Feb 21, 2024

This PR

  • adds workflow for linting PR title
  • adds workflow to automate the release process with Release Please

Related Issues

Notes

Builds on top of #36

How to test

Manually tested on my fork without the publishing step.

Hooks:

Provider:

Full list of releases: https://github.com/thisthat/python-sdk-contrib/releases

beeme1mr and others added 5 commits January 24, 2024 22:51
Signed-off-by: Michael Beemer <michael.beemer@dynatrace.com>
Signed-off-by: Michael Beemer <michael.beemer@dynatrace.com>
Signed-off-by: Michael Beemer <michael.beemer@dynatrace.com>
Signed-off-by: Michael Beemer <michael.beemer@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat requested a review from a team as a code owner February 21, 2024 21:00
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85661ff) 90.55% compared to head (bc93bcc) 90.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files           8        8           
  Lines         180      180           
=======================================
  Hits          163      163           
  Misses         17       17           
Flag Coverage Δ
unittests 90.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@federicobond federicobond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @thisthat! I added just a couple of minor comments.

release-please-config.json Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/lint-pr.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@federicobond
Copy link
Member

@thisthat fix for failing build is here.

beeme1mr and others added 2 commits February 21, 2024 20:35
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@federicobond federicobond merged commit d8e10c7 into open-feature:main Feb 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate release process
3 participants