Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove compilation warnings #47

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: remove compilation warnings #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b23815
fix: remove compilation warnings
fabriziodemaria Sep 10, 2024
a881444
Merge branch 'main' into remove-warnings
fabriziodemaria Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/OpenFeatureTests/DeveloperExperienceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ final class DeveloperExperienceTests: XCTestCase {
let provider = InjectableEventHandlerProvider(eventHandler: eventHandler)
Task {
await OpenFeatureAPI.shared.setProviderAndWait(provider: provider)
wait(for: [readyExpectation], timeout: 1)
await fulfillment(of: [readyExpectation], timeout: 1)
initCompleteExpectation.fulfill()
}
wait(for: [notReadyExpectation], timeout: 1)
Expand All @@ -81,7 +81,7 @@ final class DeveloperExperienceTests: XCTestCase {
let brokenProvider = AlwaysBrokenProvider()
Task {
await OpenFeatureAPI.shared.setProviderAndWait(provider: brokenProvider)
wait(for: [errorExpectation], timeout: 2)
await fulfillment(of: [errorExpectation], timeout: 2)
errorProviderExpectation.fulfill()
}

Expand Down
5 changes: 3 additions & 2 deletions Tests/OpenFeatureTests/FlagEvaluationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ final class FlagEvaluationTests: XCTestCase {
}

OpenFeatureAPI.shared.setProvider(provider: provider)
wait(for: [readyExpectation], timeout: 5)
await fulfillment(of: [readyExpectation], timeout: 5)
let client = OpenFeatureAPI.shared.getClient()
let key = "key"
let booleanDetails = FlagEvaluationDetails(
Expand Down Expand Up @@ -189,7 +189,7 @@ final class FlagEvaluationTests: XCTestCase {
}

OpenFeatureAPI.shared.setProvider(provider: provider)
wait(for: [readyExpectation], timeout: 5)
await fulfillment(of: [readyExpectation], timeout: 5)

let client = OpenFeatureAPI.shared.getClient()

Expand Down Expand Up @@ -268,6 +268,7 @@ final class FlagEvaluationTests: XCTestCase {
XCTAssertEqual(details.errorCode, .providerFatal)
XCTAssertEqual(details.reason, Reason.error.rawValue)
XCTAssertEqual(details.errorMessage, "A fatal error occurred in the provider: Always broken")
XCTAssertNotNil(eventState)
fabriziodemaria marked this conversation as resolved.
Show resolved Hide resolved
}

func testClientMetadata() {
Expand Down