Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update spanish translation #91

Merged
merged 1 commit into from
Sep 17, 2024
Merged

update spanish translation #91

merged 1 commit into from
Sep 17, 2024

Conversation

varodrig
Copy link
Contributor

@varodrig varodrig commented Sep 8, 2024

This PR update the Spanish translation of the Principles and Glossary.

@varodrig
update spanish translation
c3cb560 
Signed-off-by: varodrig <varodrig@redhat.com>
@varodrig
Copy link
Contributor Author

varodrig commented Sep 8, 2024

As per discussion with the group all translations requires multiple reviewers.
cc @todaywasawesome
Eduardo offered to reviewed.

@varodrig varodrig mentioned this pull request Sep 8, 2024
Open
8 tasks
@varodrig
Copy link
Contributor Author

I'm waiting for reviewers. please review and accept or add feedback. thank you

espotti
espotti approved these changes Sep 16, 2024
View reviewed changes
Copy link

@espotti espotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw all translations ok. Spanish expressions are ok based on project context.

@varodrig
Copy link
Contributor Author

Thank you

I saw all translations ok. Spanish expressions are ok based on project context.

thank you so much @espotti

@varodrig
Copy link
Contributor Author

@todaywasawesome can you approve?

todaywasawesome
todaywasawesome approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Spanish but it sounds like we have an approval from someone who does.

@todaywasawesome todaywasawesome merged commit e78a832 into open-gitops:main Sep 17, 2024
1 check passed
@varodrig
Copy link
Contributor Author

thank you @todaywasawesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@espotti espotti espotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varodrig @todaywasawesome @espotti