Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix float loads, add dgo loading to game test #101

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

water111
Copy link
Collaborator

Implement a missing case for loading floats that was causing the compiler to error when compiling vector-dot, and add a test for this and some functions from the game which use this.

More importantly, this loads GAME.DGO as part of the game tests, which I forgot to do previously. I think KERNEL was being loaded the first time which is why not everything broke. But that means we never tested a big DGO load (checks for bugs in DGO IOP state machine code) and reloading the kernel (checks for bugs in kscheme on redefinitions) I really hope this works on windows...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 328040957

  • 18 of 24 (75.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 81.979%

Changes Missing Coverage Covered Lines Changed/Added Lines %
goalc/compiler/IR.cpp 4 5 80.0%
goalc/compiler/Val.cpp 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
goalc/emitter/IGen.h 3 96.53%
Totals Coverage Status
Change from base Build 327902243: 0.05%
Covered Lines: 15171
Relevant Lines: 18506

💛 - Coveralls

@water111 water111 merged commit dfe1293 into master Oct 26, 2020
@water111 water111 deleted the w/fix-float-loads branch October 26, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants