decomp: finish sunken-pipegame | sun-exit-chamber | beach-obs
#1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1632189658
💛 - Coveralls |
water111
requested changes
Dec 28, 2021
goal_src/levels/beach/beach-obs.gc
Outdated
| (increment-success-for-hint (game-text-id beach-eco-rock-increment)) | ||
| enter-state | ||
| (go ecoventrock-break) |
There was a problem hiding this comment.
this ecoventrock-break state should take 1 argument
goal_src/levels/beach/beach-obs.gc
Outdated
| :code | ||
| (behavior () | ||
| (local-vars (a0-0 none) (sv-128 symbol)) |
There was a problem hiding this comment.
having an argument should fix the a0-0 none here
goal_src/levels/beach/beach-obs.gc
Outdated
| enter-state | ||
| #t | ||
| (go harvester-inflate) |
There was a problem hiding this comment.
harvester-inflate should take 1 arg
goal_src/levels/beach/beach-obs.gc
Outdated
| :code | ||
| (behavior () | ||
| (local-vars (a0-0 none)) |
There was a problem hiding this comment.
having an arg will fix the none here
| (when (and (= (-> arg0 type) fuel-cell) (= (-> arg3 param 0) 'pickup)) | ||
| (let ((a0-5 (handle->process (-> self fcell-handle)))) | ||
| (when a0-5 | ||
| (let ((v1-10 (new 'stack-no-clear 'event-message-block))) |
water111
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.