Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tie] add wind effect #1046

Merged
merged 5 commits into from
Jan 3, 2022
Merged

[tie] add wind effect #1046

merged 5 commits into from
Jan 3, 2022

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Jan 2, 2022

This turned out to be more complicated than expected, and I ended up implementing an instanced renderer for the instances with wind. Unlike the original game, we do the wind math in the graphics thread.

@water111 water111 linked an issue Jan 2, 2022 that may be closed by this pull request
7 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1647291176

  • 0 of 301 (0.0%) changed or added relevant lines in 6 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 53.246%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/level_extractor/BspHeader.cpp 0 1 0.0%
common/custom_data/Tfrag3Data.h 0 2 0.0%
decompiler/level_extractor/extract_tfrag.cpp 0 10 0.0%
common/custom_data/TFrag3Data.cpp 0 22 0.0%
decompiler/level_extractor/extract_tie.cpp 0 125 0.0%
game/graphics/opengl_renderer/tfrag/Tie3.cpp 0 141 0.0%
Files with Coverage Reduction New Missed Lines %
game/graphics/opengl_renderer/tfrag/Tie3.cpp 1 0%
goalc/listener/Listener.cpp 3 84.35%
decompiler/level_extractor/extract_tie.cpp 6 0%
Totals Coverage Status
Change from base Build 1647285052: -0.2%
Covered Lines: 40850
Relevant Lines: 76720

💛 - Coveralls

@water111 water111 merged commit b999422 into master Jan 3, 2022
@water111 water111 deleted the w/tie-wind branch January 3, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tie] missing features/bugs
2 participants