Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gd files, simplify fakeiso #1053

Merged
merged 3 commits into from
Jan 5, 2022
Merged

remove gd files, simplify fakeiso #1053

merged 3 commits into from
Jan 5, 2022

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Jan 5, 2022

  • removes fake_iso.txt, now you just get all the files in out/iso available to OVERLORD
  • simplify game.gp so to have *all-cgos*, *all-vis* and *all-str* lists, to avoid writing out all the names 2x.
  • remove useless .gd files
  • remove weird old resources folder that had dummy versions of a few files
  • make things not blow up if files like SCREEN1.USA is missing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1656803019

  • 11 of 12 (91.67%) changed or added relevant lines in 3 files are covered.
  • 36 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.05%) to 53.194%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/Function/Function.cpp 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
decompiler/Function/Function.cpp 1 40.1%
game/overlord/isocommon.cpp 3 32.53%
game/system/IOP_Kernel.cpp 4 90.91%
game/overlord/iso_api.cpp 13 45.45%
game/overlord/iso.cpp 15 77.14%
Totals Coverage Status
Change from base Build 1656783342: -0.05%
Covered Lines: 40806
Relevant Lines: 76711

💛 - Coveralls

@water111 water111 merged commit 474a849 into master Jan 5, 2022
@water111 water111 deleted the w/simplify-build branch July 23, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants